Template talk:Trinket infobox

item stats

Putting the item's stats ("benefits") in the infobox looks odd, especially when there is a slotted upgrade component. I'd recommend leaving these outside the infobox, displayed similarly to the {{skill infobox}}'s variables. —Dr Ishmael 21:37, 1 August 2012 (UTC)

yeah, that could work Venom20 16:10, 2 August 2012 (UTC)

Strange formating

When you put two benifits in the variables section. There will be a space between the two benifits. This wouldn't bother me so much, if the distance between the upgrade slot line and the second benift would be so much smaller. Is there any way to get these thing equidistant? - Yandere 14:41, 5 August 2012 (UTC)

There was an extra linebreak being included from Template:Accessory infobox/benefits. —Dr Ishmael 16:13, 5 August 2012 (UTC)

Nice. I expected something like that, but I couldn't find it. - Yandere 16:35, 5 August 2012 (UTC)

I cleaned up the quotes from NPCs to make them all uniform. - Endeavor 16:53, 5 August 2012 (UTC)

cost and value

What is the diffrence? As I edited the accessories I realized there where two attributes and these two where used very inconsitant. - Yandere 17:54, 5 August 2012 (UTC)

Cost is what you have to pay to acquire the item from a vendor. I have consistently argued for leaving this out of infoboxes completely, because it is incomplete information when presented this way. You also need to know who to purchase it from and where they are located, thus it makes much more sense to present this information in a unified fashion under an Acquisition section in the article.

Value is what a merchant will pay you for the item. —Dr Ishmael 18:19, 5 August 2012 (UTC)

Ok, I feared something like this. I agree with you cost should be removed from the template and put into the Acquisition section. Oh boy and I thought the cleaning would make some progress. - Yandere 18:25, 5 August 2012 (UTC)

There's not that many pages that use the cost parameter (yet):

—Dr Ishmael 18:36, 5 August 2012 (UTC)

Edited everything. - Yandere 19:00, 5 August 2012 (UTC)

Now I finished up all the pages where karma was used in the value slot. I hope this will stay a bit consistant for now. - Yandere 21:56, 5 August 2012 (UTC)

Good catch - nothing has a value in karma, you can only sell things for coin. —Dr Ishmael 21:57, 5 August 2012 (UTC)

How about calling it "Cost" and "Sell price" or "Buy-price" and "Sell-price" or something similar? That'd take all the confusion out of it. Wombatt 21:24, 6 August 2012 (UTC)

That is a pretty good idea. The may problem I see is that the buy price is something which can vary drastically. Where you buy it and which currencies can be used to get the item can be very diffrent. The sell price on the other hand is always the same. Bu I think the idea has the right direction. - Yandere 21:31, 6 August 2012 (UTC)

Accessories and Upgrade Slots

Are there any Accessories without Upgrade Slots? And if yes, it is possible to create such a setting in this template at its current state?
Another thing is the empty upgrade slot. I think it is called 'Unused Upgrade Slot' with this capitalisation. - Yandere 17:54, 5 August 2012 (UTC)

possibly, although i have yet to find one without an upgrade slot present. It would be easy enough to modify the template if something were to arise though. There is no sense in worrying about what ifs. Venom20 22:47, 5 August 2012 (UTC)

All crafted accessories have upgrade slots, but they're filled by whatever jewel or gemstone you used at the time of crafting. Wombatt 21:26, 6 August 2012 (UTC)

Subcategory

The Category:Accessories is pretty big and will probably become bigger with release. Sould we include subcategories: Necklace, Earring, Ring and Back to clear this a bit up? - Yandere 18:03, 5 August 2012 (UTC)

I think that's a great idea. For the time being, let's leave it the way it is until release. - Endeavor 18:05, 5 August 2012 (UTC)

May I ask why? Because the update wouldn't be so complicated. - Yandere 18:12, 5 August 2012 (UTC)

Hmm... now that I see we can trim a lot of wasted time by dividing them up right now... we should. - Endeavor 18:15, 5 August 2012 (UTC)

Well, we now have subcategories... Hurray! And now I realize that I have no clue what is up with these Lucky Rabbit's Foots - Yandere 19:07, 5 August 2012 (UTC)

Make a temp category (ie red) for them? - Endeavor 20:27, 5 August 2012 (UTC)

I would say no... Sooner or later they have to fit into one of the four subcategories or they are not accessories. Forgot to Sign: Yandere 22:02, 5 August 2012 (UTC)

Capes

Is cape really the offical term? It feels weird to equip a backpack into my cape slot. - Yandere 19:18, 5 August 2012 (UTC)

Agony Resistance

Is it possible to add Agony Resistance to this template? I'm not great at wiki editing just yet, but it's showing up as "5%" on Endless Quiver (Infused) and I am not sure how to change that. Ritual 11:13, 18 November 2012 (UTC)

I've added it to {{Item stat‎}} and created {{Agony Resistance‎‎}}. I've provisionally linked it to the Infusion article. We haven't got an icon for this yet as far as I can see, but when we do, it will need to be pointed to on the Agony Resistance template. (also purge your cache by clicking on the clock to make the text appear) --Chieftain Alex 11:18, 18 November 2012 (UTC)

Misnomer

So, according to Trinket and Accessory, an accessory is a type of trinket that "doesn't fit into the other three categories [ring, necklace, cape]." However, we're using {{accessory infobox}} to categorize rings, capes, necklaces, and accessories. I don't know if we'd want to go about changing it now that it's this deeply propagated, but I wanted to bring this up all the same. —Jyavoc 21:27, 18 December 2012 (UTC)

It doesn't help that Talk:Accessory redirects to Trinket talk page. The misnomer isn't a big deal since trinket and accessory have pretty much identical meanings. Area infobox is also another archaic term.--Relyk 21:52, 18 December 2012 (UTC)

I mean, I can live with it, I suppose, because it's only showing to the wiki contributors, and it isn't the most egregious mistake that we have/could make. The only thing that would prompt me to talk about a change for these would be, even if they're entrenched right now, it'd be less work/less clutter for the histories if we changed them before more game updates are made/more instances of the template are being used/the first game expansion is release (imagine Tyria+Cantha :P). —Jyavoc 21:55, 18 December 2012 (UTC)

Change it if you can be fucked--Relyk 21:59, 18 December 2012 (UTC)

O.O I wasn't trying to offend, if I did. —Jyavoc 22:01, 18 December 2012 (UTC)

It's purely a phrase, don't worry lol. I agree with changing it.--Relyk 22:04, 18 December 2012 (UTC)

I mean, I know that you use it like that, it just caught me a bit off guard. And in any case, I'd prefer to have at least a few more people weigh in on the matter, simply because of the magnitude of the change; I'd hate to do something and have "what... the fuck did you just do?" written on my talk page. —Jyavoc 22:07, 18 December 2012 (UTC)

If you take a look at the history for Trinket, you'll see that its content used to be at Accessory until it was moved on Nov 14 (which is also why Talk:Accessory redirects to Talk:Trinket). There's some discussion about the issue here. I fully support renaming wiki components to be consistent with in-game terminology, as long as you can do it without breaking anything. (In case it's not clear: the term "trinket" comes from the trading post interface, where it's an equipment category that contains amulet, ring, accessory, and (until a recent bug) back items as subcategories.) --Felbryn 22:30, 18 December 2012 (UTC)

During beta accessories war the head article and there were back items, rings, necklaces and earrings. At release the earring slot would become the accessory slot and the necklaces would be called amulets. The head article would later be changed to trinkets. So it is not a misnomer but has historical reasons.

However, I think we should name this thing trinket infobox and have a bot change every use of the box, because not everybody remembers this naming change. - Yandere 04:52, 20 December 2012 (UTC)

It would have to be a bot, or an incredibly determined editor with nothing to do :P I posted on ishy's talk page, asking him to check out the discussion. If he approves, I think we'd be able to go ahead and make the switch. But so far, it looks like everyone is wanting the change. —Jyavoc 04:55, 20 December 2012 (UTC)

Yes, let's do this, but please let me do it with my bot account so it can be hidden from RC. —Dr Ishmael 06:09, 20 December 2012 (UTC)

I was planning on it anyways :P Though when I do bot edits, I try my best now to do them when the wiki is dead. So, I hope that's better working within the confines. If it isn't, I can adjust. But yes, thanks for taking this! —Jyavoc 06:24, 20 December 2012 (UTC)

I made the move. The old name still works as long as the redirect is in place, so you can actually take your time with converting the old articles. poke | talk 08:41, 20 December 2012 (UTC)

No offense Jyavoc, but your bot sprees do make it difficult for me to catch up on RC the next morning. I do have some custom JS that allows me to filter out all of a single user's edits from the RC list, but it obviously can't distinguish your bot edits (which I don't care about) from your normal edits (which I might be interested in). That's the point of having a separate bot account with a bot flag - that account's edits are treated specially by RC and can be shown/hidden at will (hidden by default). —Dr Ishmael 16:00, 20 December 2012 (UTC)

Lets bash bureaucrats until bot rights fall out? (also, use a longer recent changes by typing in a different number in the address bar?) 77.97.208.117 16:10, 20 December 2012 (UTC)

Binding

Certain items from Fractal of the Mists like the rings and back pieces are both account bound and soul bound on use. This is of critical importance as it means an item cannot be traded but can be given to another character. Clearly the chap here [1] was caught our by this, so would be good we can add an optional second binding type. --Lemming 15:56, 6 January 2013 (UTC)

Talk:Ascended#Unique_and_Binding ^^--Relyk ~ talk > 16:40, 6 January 2013 (UTC)

I just added a new entry to the binding template to handle these items ("absb" or "account soul" - Account Bound on acquire, soulbound on use). It's working, but someone with a better sense of style might want to take a look/clean it up a little. Hendusoone 05:53, 7 January 2013 (UTC)

Ok I updated some of the quivers. I have to go soon, so if someone could get the rest of the ascended back pieces updated that would be excellent. Shimpchip talk 10:41, 7 January 2013 (UTC)

gallery

Why does this show the gallery for everything? That should be limited to back items - rings, amulets, and earrings/accessories have no visual representation on your character. —Dr Ishmael 02:03, 9 January 2013 (UTC)

I've just set it to show the "upload a file" message if its a back/cape item by default, but I've left in the option to use the gallery for anything else in case there is some corner-case which needs a picture.. (only displays if gallery1 is set though) Chieftain Alex 09:45, 9 January 2013 (UTC)

Template changes to Upgrade slot

The change earlier fixed the double icons in the upgrade slot ("uslot = Adorned Garnet Jewel" would show both its icon and an "unused" icon). Now, however, using "unused" as a variable for "uslot" doesn't work correctly and displays as code. I did edit it a moment ago as I noticed a missing brace in there thinking that may have been all it was, but it merely fixed a redlink. This is what I'm attempting to explain.

An obvious course of action would be to leave the "uslot" parameter blank, or completely leave the parameter out for trinkets without a used upgrade slot. That, however, may not be what everyone wants. Anyway, thought I'd point that out to you guys. — Leviticus Lo 02:04, 8 February 2013 (UTC)

To be honest version 1 and version 3 is how it should look like. And I really don't see a point in the unused page. I see however that you would want something like

| uslot = unused

| uslot = 

to produce both the same result as version 3 so you could set the variable explicit to unused instead of impliced. - Yandere 02:27, 8 February 2013 (UTC)

Oh and just because I have seen Doc Ishmaels last edit. I never understood the upgrade slot icon as default icon, more like a place marker for the upgrade slot and also to have a link to upgrade component where the whole mechanic is explained. - Yandere 02:37, 8 February 2013 (UTC)

The template mimics the upgrade slot icon in-game, the entire line including the icon acts as a placeholder until you insert an upgrade component. That doesn't mean we have to omit the upgrade slot icon of course. The item itself will provide navigation to the upgrade slot, so it's not an issue; although I'm sure someone will complain we need to do so...--Relyk ~ talk > 03:14, 8 February 2013 (UTC)

What I'm trying to say is using "unused":

| uslot = unused

now shows part of the code as this. Before the changes, it would work the same as leaving it blank:

| uslot = 

and appear correctly, like this. Something was changed to make the former not work the same as the latter. I don't know how to fix it, so I wanted to let you guys know.

Also, I don't know if it has anything to do with it, but it shows part of Line 49. — Leviticus Lo 03:29, 8 February 2013 (UTC)

There, I fixed it. It's not really a good practice to give explicit input that produces output identical to default, but I don't feel like editing all the pages that use it right now. —Dr Ishmael 04:41, 8 February 2013 (UTC)

Why is it not a good practice? --Felbryn 23:41, 8 February 2013 (UTC)

You're setting a value to a parameter that acts as a null instead of leaving the value as a null (or white space). It causes the statement {{#if: {{{uslot|}}} |<true>|<false>}} to return true when you want it to return false and display the default output. To fix it, you have to code it as {{#ifeq: {{{uslot|}}} |<null flag>|<false>|<true>}} to achieve the same result.--Relyk ~ talk > 00:00, 9 February 2013 (UTC)

So the concern is that it's awkward to code, and therefore makes the template harder to maintain? (As opposed to, for example, making it harder to use, or causing performance issues, or something.) Just wondering. --Felbryn 00:19, 9 February 2013 (UTC)

We could actually go further and make any value that isn't an item generate the default output: User:Relyk/Sandbox. The reason we don't is because we need feedback on if the item exists or not. If you put in "empty", "unused upgrade slot", or "unused slot" (used on the weapon infobox), this will generate an invalid icon because those aren't items and we didn't address the values in our logic. Hope that's helpful.--Relyk ~ talk > 02:25, 9 February 2013 (UTC)

One of the recent changes seems to have broken something else. Prototype Fractal Capacitor specifies "uslot = no", and this used to prevent the upgrade slot from appearing, but now it shows an empty-slot icon with a red-linked "no". --Felbryn 06:53, 9 February 2013 (UTC)

I just said any other string would generate an invalid icon :3--Relyk ~ talk > 07:13, 9 February 2013 (UTC)

Technically, you didn't. You said that "empty", "unused upgrade slot", or "unused slot" would generate an invalid icon. Regardless, I'm pretty sure this used to work, and there are items in the game without upgrade slots, so we need some way of specifying that in the template. --Felbryn 07:35, 9 February 2013 (UTC)

That's a separate issue, but you seem rather distraught about it so I'll just nod my head and agree with you.--Relyk ~ talk > 09:25, 9 February 2013 (UTC)

There! Fixed the no... - Yandere 13:22, 9 February 2013 (UTC)

ascended items in trinket infobox

The Infobox for ascended items contains a code for infusion types, but doesn't generate "Utility" infusion, with the new amulets and infusions in game it would be good to change this so that it's specified more clearly. Smoke 04:13, 7 February 2013 (UTC)

ascended items do not already have a infusion when you purchase them. In other word they come with unused slots and the following lines of code cover this:

|utility
|utility infusion =''Unused Utility Infusion Slot''

- Yandere 14:43, 10 February 2013 (UTC)

Infusion slots on non-ascended items

The Sclerite Karka Shell and Fervid Censer have defensive infusion slots, despite not being ascended. It appears the template currently doesn't support that. --Felbryn (talk) 07:38, 18 May 2013 (UTC)

Supported now, with an example included. The name "slot type" will look funny because our "slot" parameter should actually be "type" for the type of trinket.--Relyk ~ talk < 04:09, 22 May 2013 (UTC)

Maybe you should've made the new one "uslot type" to match the existing "uslot". —Dr Ishmael 04:16, 22 May 2013 (UTC)

Because "uslot type = infusion" makes no sense. It's probably too late to push for that though.--Relyk ~ talk < 04:24, 22 May 2013 (UTC)

slot mismatch defaults to accessory

The original Fervid Censer article had "slot=back item" instead of "slot=back" and the infobox code turned that into category:accessories. Maybe the code for the info boxes should return an error instead of a default. 75.37.23.153 01:55, 26 May 2013 (UTC)

Thanks for fixing it. 75.37.23.153 06:06, 26 May 2013 (UTC)

Minor bug in Template

(edit: has been fixed by Relyk )

If someone adds the (optional) description field, but leaves it empty (ie "| description = ", the whole paragraph including the stats variables are not shown on the page. Removing the empty description line from the Trinket infobox make the stats re-appear. For an example see http://wiki.guildwars2.com/wiki/Quiver_of_Swift_Flight and the edit history from a few minutes ago.

Or see here (see page code for the difference).

Without description line:

{{Trinket infobox
| type = cape
| variables = {{Item stat|power|56}}{{Item stat|Precision|35}}{{Item stat|Critical Damage |5}}
| uslot = offensive
| level = 80
| rarity = Ascended
| cost = 
| value = 
| bound = account soul
| gallery1 = Bowyer's Delight.jpg
}}

With empty description line:

{{Trinket infobox
| type = cape
| description = 
| variables = {{Item stat|power|56}}{{Item stat|Precision|35}}{{Item stat|Critical Damage |5}}
| uslot = offensive
| level = 80
| rarity = Ascended
| cost = 
| value = 
| bound = account soul
| gallery1 = Bowyer's Delight.jpg
}}

Leaving as code so it's readable and doesn't set properties or anything ^^. People can preview the code anyways. The problem was the logic check if a description was defined, then the if statement checks if the the argument is null (which happens if it's whitespace). Because the description was null (whitespace), the statement returned false and didn't display anything. If description wasn't defined, it would then check if variables was defined, which it was, and would display correctly. Switched the logic to check each variable, which is the more typical approach. Usually, null parameters should be removed, but the description can be blank, so we get caught on that. Hope I don't sound confusing.--Relyk ~ talk < 20:30, 30 June 2013 (UTC)

Great! Thanks for the fast fix :)

Salvage

The infobox does not seem to have a parameter to indicate an item can't be salvaged. MithTalk 18:35, 7 May 2014 (UTC)

Infused, Attuned, or both

Some trinkets (namely rings and/or backpieces) can be Attuned, Infused, or both. So, perhaps having two more optional parameters would help:
attuned = yes/no [optional]
infused = yes/no [optional]
For the attuned and infused pages, the list of attuned or infused equipment is listed by querying the site with #ask. However, there is no way to distinguish regular from infused from attuned from both. Having those parameters and subsequent query statements (Is attuned trinket::Y and Is infused trinket::Y) would fix that, I believe. Hekela (talk) 11:54, 15 November 2015 (UTC)

Agreed, and this is clearly better than the "aslot=1|2" that I was about to implement. So my plan of action is going to be: add attuned/infused to the template parameters, add "Is infused" and "Is attuned" properties, but continue setting "Has infusion slot" anyway (because it's a list of infusion slots on the item... but unfortunately I don't think SMW will let us set the same property multiple times, so it'll have to say "Offensive,Agony" rather than "Offensive,Agony,Agony" like it should). Then go through all the pages using aslot=yes/attuned and change them to the new properties. And update {{Back item infobox}} to match. Then document everything, because it sucks having to read template source to find the hidden parameters you're supposed to use. My only concern is that it might seem that Is infused::Y should be set for random ascended gear which has an offensive/defensive/utility infusion slot but is not actually infused. But I guess that's just an unfortunate result of Anet's confusing naming. -- Dagger (talk) 15:57, 27 December 2015 (UTC)

Most of the above sounds good to me, so if I understand correctly the parameters relevant to infusion would be:

Case	Example item	Parameters	Result
Not infused	Sapphire Heart	(no parameters filled in)	(blank)
Plain (1x Utility/Offensive/Defensive slot)	Ring of Red Death	| aslot = Offensive	Unused Offensive Infusion Slot
Infused (1x Utility/Offensive/Defensive slot and 1x Agony Resistance slot)	Ring of Red Death	| aslot = Offensive | infused = y	Unused Offensive Infusion Slot Unused Agony Infusion Slot
Attuned (1x Utility/Offensive/Defensive slot and 1x Agony Resistance slot)	Attuned Ring of Red Death	| aslot = Offensive | attuned = y	Unused Offensive Infusion Slot Unused Agony Infusion Slot
Attuned and Infused (1x Utility/Offensive/Defensive slot and 2x Agony Resistance slot)	Attuned Ring of Red Death (Infused)	| aslot = Offensive | attuned = y | infused = y	Unused Offensive Infusion Slot Unused Agony Infusion Slot Unused Agony Infusion Slot

Proposed new properties: Property:Is infused (y/n), Property:Is attuned (y/n).

Existing properties: Property:Has infusion slot (should only be a single text value, either omni/defensive/offensive)

Since we already save the accessory/weapon/armor type we know how many "core" (for want of a better word for the omni/defensive/offensive bits) slots each item has (so we can post-process the appearance of those based on the other 3 parameters). I don't think that maintaining a list of the slots it has is useful to be honest (which seems to be what Dagger is proposing?)

My only concern here is that "aslot" isn't a descriptive parameter name, but I guess its ok. -Chieftain Alex 18:57, 27 December 2015 (UTC)

I was planning to leave the core infusion slot (which is currently specified by uslot) alone, and remove aslot. If you move the core infusion slot to aslot then you've got to work out how it interacts with uslot, plus change way more pages. Maybe we should take the chance to neaten these parameters up though.

(I was also going to leave Property:Has infusion slot alone, mainly because I feel like I've shaved enough yaks in the course of adding the attuned ring pages as it is. Tracking a list of agony slots does seem like it ought to be useful (and note that's how the API tracks infusion slots too), but I couldn't find any uses of it on the wiki, so maybe not.)

Whichever way we go, don't forget that Sclerite Karka Shell says hello (but since it's been broken since it was added I guess we don't care very much about it). -- Dagger (talk) 19:55, 27 December 2015 (UTC)

{{parameter check|trinket infobox|rarity:unique:uslot:aslot|50|class=expandable}}

I don't care about yak-shaving, I can do that with my robot. I think where infusions are specified in uslot they need removing. -Chieftain Alex 20:59, 27 December 2015 (UTC)

Agreed. Make it so, then ;) As I see it, the necessary changes are uslot=offensive/defensive/utility needs to be moved to aslot and the current aslot=yes/attuned values need to be moved to infused=yes. (And then attuned=/infused= need fixing up for the attuned item pages, but I can just do the few of those when I add the rest.) Then the template needs updating to set uslot to no by default if aslot is set (or maybe it'd be better to explicitly set uslot=no?). This would be a good opportunity to rename aslot too, although there's the unsolved question of what to rename it to. -- Dagger (talk) 21:56, 27 December 2015 (UTC)

aslot → "infusion slot" would be my preference... -Chieftain Alex 22:49, 27 December 2015 (UTC)

Multiple slots

Many trinkets now have multiple slots. Possible combinations include:

• Upgrade + Infusion
• Infusion + Agony

How can multiple slots be specified? The documentation should include these examples and better explain agony infusion slots on infused ascended trinkets. ~ 1Maven (talk) 15:52, 1 December 2015 (UTC)

Enrichment slot error/warning

Although at the moment the option of enrichment slot seem to 'work' it still returns an error saying enrichment is not an accepted infusion type; see here. I'm thinking there is a check somewhere in the template which was not updated when enrichment was added to the template. -Darqam (talk) 17:43, 4 August 2016 (UTC)

Surely you've seen the SMW error triangle tag before? (inspect html element). fix -Chieftain Alex 17:54, 4 August 2016 (UTC)

Yeah I've seen it before; but usually it was when I did something bad. So I wasn't sure how to go about fixing it. I also had no idea it was called a SMW error triangle. For me it was always a "You done screwed up" alert. -Darqam (talk) 19:02, 4 August 2016 (UTC)

Prefix name

This was posted somewhere already, but would it be smart to include the prefix's name in the description of the infobox? I know not every reader will know what power/precision/ferocity is, so including it in the description might alleviate potential confusion. —Ventriloquist 20:12, 5 April 2018 (UTC)

Sounds fine to me. My only question now is do we add it to the other infoboxes too, e.g. weapon/armor/back item infobox, in which case might be better to go via {{default item parameter}}. -Chieftain Alex 20:22, 5 April 2018 (UTC)

Oh, yeah. While plenty of weapons/armors are prefix...less and stat-selectable, it definitely wouldn't hurt. —Ventriloquist 20:29, 5 April 2018 (UTC)