Property talk:Has equipment prefix

From Guild Wars 2 Wiki
Jump to navigationJump to search

Multi-value property[edit]

I'm thinking it would be useful to have a second property named something like "Has available equipment prefixes" that allows us to query for Viper's trinkets for example - vipers is an option which comes under some versions of stat-select, but not all, so we don't always see this in our queries using current properties.

Alternatively we could come up with some different versions of "Selectable" (e.g. "Selectable" could be all stats, "Selectable core" could be stats from the core game, and "Selectable hot" could be the stats from HoT) and store them in this property. Some of our templates would need a bit of a kick though. -Chieftain AlexUser Chieftain Alex sig.png 17:59, 7 October 2016 (UTC)

or match the api and use stat ids ("stat_choices":[588,656,659,658,660,584,586,583,657,585,592,581,591])--Relyk ~ talk < 20:52, 7 October 2016 (UTC)
Hmm wouldn't that be a pain in the butt to query on? (user could enter text, it looks up the prefix id, then queries?) -Chieftain AlexUser Chieftain Alex sig.png 22:12, 7 October 2016 (UTC)
No? If anything, it makes it less of a pain. We already have {{prefix attributes}} that makes it really easy to implement.--Relyk ~ talk < 22:39, 7 October 2016 (UTC)
Okay. Can you give an example of how you think we should pass the soon-to-be-property data to the page using the infobox?
On page:
{{weapon infobox
| prefix = selectable
}}
In the infobox template:
{{prefix attributes|{{{prefix}}}}}
{{#set: Has available equipment prefixes = {{prefix ids|{{{prefix}}}}} |+sep=;}}
In the ids template:
{{#switch: {{#replace:{{lc:{{{1|}}}}}|'s|}}
 | assassin = 1
 | berserker = 2
 | commander = 3
 | viper = 4
 | selectablecore = 1;2;3
 | selectablehot = 4;5
 | selectable = 1;2;3;4;5
}}
-Chieftain AlexUser Chieftain Alex sig.png 10:50, 8 October 2016 (UTC)
{{weapon infobox
| prefix = 1,2,3,4,5
| selectable = true
}}
{{#arraymap:{{{prefix}}}|,|@@@|
[[Has equipment prefix::{{prefix id|@@@}}]]
}}
And a Is selectable flag to tell us how to interpret multiple prefixes. I meant adding the stat id to the lookup table of {{prefix attributes}} so it looks like {{prefix attributes| {{{prefix}}} }}, where we wouldn't have to change any templates that depend on prefix attributes.--Relyk ~ talk < 19:47, 8 October 2016 (UTC)
Implementation sounds like you've thought about it, which is good. Why couldn't we just use the name of each stat for the property value instead of the id? -Chieftain AlexUser Chieftain Alex sig.png 21:01, 8 October 2016 (UTC)
Not sure if you intended to imply that I don't in fact think about what I implement... should be self-explanatory that ids are much easier to work with than strings and we match the API.--Relyk ~ talk < 21:58, 8 October 2016 (UTC)
It might be easier to understand for users if we use the text names for prefixes. I can add the various prefixes with my bot anyway, so we need not be concerned about the simplicity of copying the numberic array from the API query. -Chieftain AlexUser Chieftain Alex sig.png 22:14, 8 October 2016 (UTC)
I'm not sure what your point is. Users will still being using the name in templates and such.--Relyk ~ talk < 18:05, 14 October 2016 (UTC)
Okay sorry Relyk, I'm not seeing why numbers would be in any way superior to names. -Chieftain AlexUser Chieftain Alex sig.png 18:39, 14 October 2016 (UTC)
Discussing whether a number is superior to a name is pointless in the first place? The only one interested in that discussion seems to be you. The reason to use the id is the same exact reason you use ids for everything else. The name isn't guaranteed to be unique and strings are a pain to work with. Prefixes like Giver's have multiple ids. Some of the prefix names end with 's and some don't. There are also item stats without a name.--Relyk ~ talk < 19:31, 14 October 2016 (UTC)

Changes to prefix name for ascended items (removal of "at_<name>")[edit]

Hey guys, I'm rewritten some of the prefix templates to remove the need to specify "at_" before prefixes on ascended/legendary trinkets/back items. I always thought this was a stupid notation. I'm changing the prefix codes with a bot at the moment.

Templates edited:

  • {{Prefix attributes}} - backwards compatible; this template now has supertype and rarity parameters which make it look for the prefixes previously prefixed "at_". I also intend to remove this backwards compatibility after the run is complete.
  • {{Back item infobox}} - passed the rarity and supertype parameters to prefix attributes
  • {{Trinket infobox}} - as above
  • {{Item variant table row}} - as above
  • {{Vendor table row result format}} - as above
  • {{Prefix selection}} - also backwards compatible at the moment, with the intent of removing old names for "at_" prefixes once the robot run is complete.

I'm not editing dungeon table row/fm table because they don't sell ascended/legendary gear. Any templates I've missed? -Chieftain AlexUser Chieftain Alex sig.png 13:33, 8 January 2017 (UTC)